Changeset 548


Ignore:
Timestamp:
Nov 8, 2012, 5:57:54 PM (10 years ago)
Author:
Kris Deugau
Message:

/trunk

Clean up another couple of syntax-mess warnings. See #31.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/cgi-bin/admin.cgi

    r547 r548  
    6969}
    7070
     71if(!defined($webvar{action})) {
     72  $webvar{action} = "main";   #shuts up the warnings.
     73}
     74
    7175# handle DB error output
    7276if ($webvar{action} eq 'dberr') {
     
    8791
    8892my $header = HTML::Template->new(filename => "admin/header.tmpl");
    89 
    90 if(!defined($webvar{action})) {
    91   $webvar{action} = "main";   #shuts up the warnings.
    92 }
    9393
    9494my $page;
     
    567567# List all IPs in a pool, and allow arbitrary admin changes to each
    568568# Allow changes to ALL fields
    569 sub showPool($) {
     569sub showPool {
    570570  my $pool = new NetAddr::IP $_[0];
    571571
     
    582582  $page->param(typelist => \@typelist);
    583583
    584   $sth = $ip_dbh->prepare("select ip,custid,city,type,available,description,notes from poolips where pool='$pool' order by ip");
    585   $sth->execute;
     584  $sth = $ip_dbh->prepare("SELECT ip,custid,city,type,available,description,notes from poolips".
     585        " WHERE pool=? ORDER BY ip");
     586  $sth->execute($pool);
    586587  my @iplist;
    587588  while (my ($ip,$custid,$city,$type,$avail,$desc,$notes) = $sth->fetchrow_array) {
Note: See TracChangeset for help on using the changeset viewer.