Opened 11 years ago

Closed 7 years ago

Last modified 6 years ago

#26 closed task (fixed)

Weed out ViaNet-isms

Reported by: Kris Deugau Owned by:
Priority: minor Milestone:
Version: Keywords:
Cc:

Description

Trim out or generalize any remaining hardcoded ViaNet?-specific bits.

Most of these are docu-comments referring to ViaNet? IP ranges.

Change History (17)

comment:1 Changed 11 years ago by Kris Deugau

(In [427]) /trunk

Trim reference to ViaNet? IP ranges in help.html and search.cgi (see #26)

comment:2 Changed 11 years ago by Kris Deugau

(In [428]) /trunk

Checkpoint - this change still needs testing
Trim reference to ViaNet? IP ranges in IPDB.pm (see #26) by

generalizing netblock-in-DSL-pool deallocation (part of #6)

Note the diff is larger than the real change due to whitespace shuffling

comment:3 Changed 11 years ago by Kris Deugau

(In [442]) /trunk

Remove some ViaNet?-isms (reference to city names with primary POPs).
See #26.
Update alloctypes.html to reflect current preseeded alloctypes

comment:4 Changed 11 years ago by Kris Deugau

(In [455]) /trunk

Remove reference to legacy oldcustid field - leftovers from a
billing system transition. See #26.

comment:5 Changed 11 years ago by Kris Deugau

(In [479]) /branches/htmlform

Convert initial DB connection error output to a sane page. Could arguably provide
space for this (and other) errors on all normal pages. (See #3).
This allows us to:

  • Remove editError sub in main.cgi
  • Remove printHeader sub in CommonWeb?.pm (see #15, #26)

Removed duplicate "exit if we get this far"
Tweak IPDB::finish so it doesn't spit a fatal error when called with a null database handle

comment:6 Changed 11 years ago by Kris Deugau

(In [480]) /branches/htmlform

Forgot to remove some refs to printHeader in CommonWeb?.pm in r479 (see #15, #26)
Add the Invitable Forgotten New File (DB error template)

comment:7 Changed 11 years ago by Kris Deugau

(In [481]) /branches/htmlform

Update search.cgi to use a few templates (see #3 - note search.cgi NOT completely
updated for HTML only in templates), remove search.cgi references to printError
from CommonWeb?.pm (see #15, #26).

comment:8 Changed 11 years ago by Kris Deugau

(In [483]) /branches/htmlform

Start converting admin.cgi to templates (to make removal of references to CommonWeb?.pm
subs simpler; see #3, #15, #26)
Completed:

  • Main page
  • ACL error page
  • rWHOIS customer data editing - list, edit new/update, confirm update

comment:9 Changed 11 years ago by Kris Deugau

(In [487]) /branches/htmlform

Finish IP pool tweaking
Complete email notice configuration
Finish most of block allocation
Add generic error page
Fix admin header with reference to Javascript bits
See #3, #15, #26

comment:10 Changed 11 years ago by Kris Deugau

(In [489]) /branches/htmlform

Remove use of printError() in admin.cgi. See #15, #26

comment:11 Changed 11 years ago by Kris Deugau

(In [490]) /branches/htmlform

Remove ref to printAndExit from allocate.pl (irrelevant anyway since it's not a web
tool). See #3, #15, #26.

comment:12 Changed 11 years ago by Kris Deugau

(In [491]) /branches/htmlform

Convert dangling DB error to template in admin.cgi; remove all refs to printAndExit().
See #3, #15, #26.

comment:13 Changed 11 years ago by Kris Deugau

(In [493]) /branches/htmlform

Convert dangling direct error print to template parameter (can't load node list for
search). See #3.
Remove dangling obsolete commented code fragments and subs (printRow and startTable).
See #3, #26.

comment:14 Changed 11 years ago by Kris Deugau

(In [495]) /branches/htmlform

Converted main.cgi "invalid action" into template. See #3.
"Cleaned up" error messages for an invalid action, removed call to printAndExit(). See #15, #26.

comment:15 Changed 10 years ago by Kris Deugau

(In [502]) /branches/htmlform

Remove stale, unused cleanInput(), desanitize() subs in CommonWeb?.pm
Quickly hack up search.cgi to remove printAndExit() from CommonWeb?.pm
See #15, #26

comment:16 Changed 7 years ago by Kris Deugau

Resolution: fixed
Status: newclosed

Resolving this ticket as the public code base has been cleaned up and generalized.

comment:17 Changed 6 years ago by Kris Deugau

(In [839]) /trunk

Convert a lingering custom patch to another configuration knob. See #26.

Note: See TracTickets for help on using tickets.